Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Add side to grouped bar plugin, fix alignment with different sides #1022

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Add side to grouped bar plugin, fix alignment with different sides #1022

wants to merge 2 commits into from

Conversation

gelicia
Copy link

@gelicia gelicia commented Dec 11, 2024 •
edited
Loading

This does not fix every axis/alignment scenario

  • Adds an example with axes on the top, right, bottom and left. Each axes example has an example with the text being left or right aligned
  • adds an optional ability to align text in the grouped bar plugin
  • Adds logic to uplot where if the orientation is horizontal, it will align text to 0 or the chart width when the text is aligned left or right.

Left set of examples is before the change, right is after the change.
Screenshot 2024-12-11 at 9 22 49 AM

Related to grafana/grafana#94344

gelicia
gelicia commented Dec 11, 2024
View reviewed changes
dist/uPlot.iife.js
else
else {
if (axis.side === 1 && axis.align === 2)
x = can.width;
Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm guessing 0 to canvas width is not the correct boundaries we want - what are the best offsets?

# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gelicia