-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Feature request: Using different claim for OIDC username #596
Comments
I don't believe Github supports OIDC. Not as an identity provider anyway. I think it only supports OAuth, hence people using OTF don't use the OIDC flags for Github, but But that is by the by. I think it's reasonable to provide the additional flag as you're asking for. |
Oh course, didn't read the documentation properly, Github uses different mechanisms. My bad. Thanks for looking into this. |
leg100
added a commit
that referenced
this issue
Sep 13, 2023
leg100
pushed a commit
that referenced
this issue
Sep 13, 2023
🤖 I have created a release *beep* *boop* --- ## [0.1.13](v0.1.12...v0.1.13) (2023-09-13) ### Features * add flags --oidc-username-claim and --oidc-scopes ([#605](#605)) ([87324d0](87324d0)), closes [#596](#596) ### Bug Fixes * restart spooler when broker terminates subscription ([#600](#600)) ([ce41580](ce41580)) * retrieving state outputs only requires read role ([#603](#603)) ([25c4a99](25c4a99)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Would it be possible to have the username claim using
email
instead ofname
for the claim?Using Github as OIDC provider,
name
is garunteed to be unique, however using AzureAD this is not the case, butemail
is most definitely unique.seeing as a number of people probably using GitHub as IDP, perhaps which claim to use can be a paramater being specified at deploy time?
for example:
The text was updated successfully, but these errors were encountered: