Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Gitlab repo download fails #651

Closed
NegativeFeedback opened this issue Nov 23, 2023 · 3 comments · Fixed by #665 or #667
Closed

Gitlab repo download fails #651

NegativeFeedback opened this issue Nov 23, 2023 · 3 comments · Fixed by #665 or #667

Comments

@NegativeFeedback
Copy link

NegativeFeedback commented Nov 23, 2023 •
edited
Loading

I am on otf 0.1.18 running docker containers on nomad with projects on gitlab, When I attempt a plan or apply with VCS now it fails with
"retrieving repository tarball: malformed directory name found in tarball"
and
:ERROR constructing new run error="retrieving repository tarball: malformed directory name found in tarball: cloudflare-main-***" subject="
@leg100
Copy link
Owner

leg100 commented Nov 24, 2023

Thanks for the raising the issue. The Gitlab support is less than robust, so I'm not wholly surprised. I'll take a look and see what I can do.

@NegativeFeedback
Copy link
Author

awesome thanks! Please let me know if I can grab any other logs or anything else

@jpetrucciani jpetrucciani mentioned this issue Dec 4, 2023
Merged
@jpetrucciani
Copy link
Contributor

We've run into this as well - it would appear that the directory name inside the tarball may have changed to be $project-$branch-$hash - I've opened a PR with a potential fix at #654

leg100 pushed a commit that referenced this issue Dec 6, 2023
@jpetrucciani
fix: add extra case for gitlab repo dir name (#654)
5424565 
This was a small change we had to make for solving the issue with #651
wherein we see a different name structure for the directory within the
tarball that we get from gitlab
@leg100 leg100 mentioned this issue Dec 9, 2023
Merged
leg100 added a commit that referenced this issue Dec 12, 2023
@leg100
fix: gitlab support (#665)
eaf9b15 
This PR builds upon #654 to fix further Gitlab issues, and to bring it
generally into line with the Github support.

Fixes #651
@github-actions github-actions bot mentioned this issue Dec 12, 2023
Merged
leg100 pushed a commit that referenced this issue Dec 12, 2023
@github-actions
chore(master): release 0.2.3 (#667)
b518d44 
🤖 I have created a release *beep* *boop*
---


## [0.2.3](v0.2.2...v0.2.3)
(2023-12-12)


### Bug Fixes

* gitlab support ([#665](#665))
([eaf9b15](eaf9b15)),
closes [#651](#651)

---
This PR was generated with [Release
Please](https://github.com/googleapis/release-please). See
[documentation](https://github.com/googleapis/release-please#release-please).

Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
@github-actions github-actions bot mentioned this issue Jan 11, 2025
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@leg100 @NegativeFeedback @jpetrucciani