Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

add @types/node-fetch as dependency #506

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

andsouto
Copy link
Contributor

I was obtaining this error:

✘ [ERROR] TS7016: Could not find a declaration file for module 'node-fetch'. '/home/andres/c2c-angular/node_modules/node-fetch/lib/index.js' implicitly has an 'any' type.
  Try `npm i --save-dev @types/node-fetch` if it exists or add a new declaration (.d.ts) file containing `declare module 'node-fetch';` [plugin angular-compiler]

    node_modules/stanza/platform/node/index.d.ts:2:18:
      2 │ import fetch from 'node-fetch';
        ╵                   ~~~~~~~~~~~~

And including @types/node-fetch in dependencies fixes it. I think it makes sense including types for that dependency the same way are being included for the rest of them.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant