Fix client_id/client_secret string requirements #171
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The OAuth2 spec allows these to be zero or more characters. https://tools.ietf.org/html/draft-ietf-oauth-v2-31#section-2.3.1
The OAuth2 spec allows these to be zero or more visual ASCII characters. https://tools.ietf.org/html/draft-ietf-oauth-v2-31#appendix-A.1 > VSCHAR = %x20-7E > > A.1. "client_id" Syntax > The "client_id" element is defined in Section 2.3.1: > client-id = *VSCHAR > > A.2. "client_secret" Syntax > The "client_secret" element is defined in Section 2.3.1: > client-secret = *VSCHAR
rwe
force-pushed
the
client-secret-not-required
branch
from
55c7972 to
79873bd
Compare
|
@erydo Thanks, will release a new version as soon as possible. |
This was referenced Jan 27, 2020
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The OAuth2 spec allows these to be zero or more visual ASCII characters.
https://tools.ietf.org/html/draft-ietf-oauth-v2-31#appendix-A.1
This PR includes two changes. The first is to explicitly allow empty strings. (Joi requires this to be explicit). The second commit restricts the character set to the range given in the spec, which is all visual non-control ASCII characters.
Fixes #170