Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Windows build fixes #159

Merged
merged 1 commit into from
Mar 26, 2020
Merged

Windows build fixes #159

merged 1 commit into from
Mar 26, 2020

Conversation

jakolehm
Copy link
Contributor

No description provided.

@jakolehm jakolehm added the bug Something isn't working label Mar 26, 2020
@jakolehm jakolehm added this to the 3.1.0 milestone Mar 26, 2020
@jakolehm jakolehm requested a review from a team March 26, 2020 15:46
@jakolehm jakolehm force-pushed the fix/windows-build branch from 4b6df54 to fb886ee Compare March 26, 2020 18:07
miskun
miskun approved these changes Mar 26, 2020
View reviewed changes
Copy link
Member

@miskun miskun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakolehm
fix windows build
c314b68 
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
@jakolehm jakolehm force-pushed the fix/windows-build branch from fb886ee to c314b68 Compare March 26, 2020 18:32
nevalla
nevalla approved these changes Mar 26, 2020
View reviewed changes
Copy link
Contributor

@nevalla nevalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jakolehm jakolehm merged commit 4ead24b into master Mar 26, 2020
@jakolehm jakolehm deleted the fix/windows-build branch March 26, 2020 18:40
@jakolehm jakolehm mentioned this pull request Mar 27, 2020
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@miskun miskun miskun approved these changes

@nevalla nevalla nevalla approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
3.1.0
Development

Successfully merging this pull request may close these issues.
3 participants
@jakolehm @nevalla @miskun