Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Show always Events title in resource details #286

Merged
merged 1 commit into from
Apr 21, 2020
Merged

Show always Events title in resource details #286

merged 1 commit into from
Apr 21, 2020

Conversation

nevalla
Copy link
Contributor

@nevalla nevalla commented Apr 20, 2020 •
edited
Loading

This PR will show Events title in resource details even when no events available for the resource. Also dropped the icon for the consistency.
image

Fixes #261

@nevalla
Show always Events title in resource details
c7237da 
Signed-off-by: Lauri Nevala <lauri.nevala@gmail.com>
@nevalla nevalla added the enhancement New feature or request label Apr 20, 2020
@nevalla nevalla requested a review from a team April 20, 2020 19:54
@jakolehm jakolehm added this to the 3.4.0 milestone Apr 21, 2020
@jakolehm jakolehm merged commit 634cca2 into master Apr 21, 2020
@jakolehm jakolehm deleted the feature/always-show-title-in-event-details branch April 21, 2020 16:51
@jakolehm jakolehm mentioned this pull request Apr 28, 2020
Merged
@jakolehm jakolehm mentioned this pull request May 9, 2020
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jakolehm jakolehm jakolehm approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
3.4.0
Development

Successfully merging this pull request may close these issues.

show Events title in in pod also when no events
2 participants
@nevalla @jakolehm