Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Dynamic dashboard UI based on RBAC rules #366

Merged
merged 4 commits into from
Jun 5, 2020
Merged

Conversation

jakolehm
Copy link
Contributor

Continues work started in #297

@jakolehm jakolehm requested a review from a team May 12, 2020 17:20
@jakolehm jakolehm added the enhancement New feature or request label May 12, 2020
@jakolehm jakolehm mentioned this pull request Jun 1, 2020
@jakolehm jakolehm added this to the 3.5.0 milestone Jun 1, 2020
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
@jakolehm jakolehm marked this pull request as ready for review June 1, 2020 13:08
@jakolehm
Copy link
Contributor Author

jakolehm commented Jun 1, 2020

@lensapp/lens-maintainers PTAL

Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
@jakolehm
Copy link
Contributor Author

jakolehm commented Jun 4, 2020

@lensapp/lens-maintainers PTAL

Signed-off-by: Jari Kolehmainen <jari.kolehmainen@gmail.com>
Copy link
Contributor

@nevalla nevalla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@erick-thompson
Copy link

I know this is a merged PR, but I have a user that can no longer see any Secrets in the Lens UI, even though he can view/edit secrets via kubectl. It happened fairly recently, so I'm wondering if this could be related.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants