Fix kubectl binary version check #510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…on instead of using the eTag Signed-off-by: Jim Ehrismann <jehrismann@mirantis.com>
Closed
nevalla
pushed a commit
that referenced
this pull request
Jun 24, 2020
…on instead of using the eTag (#510) Signed-off-by: Jim Ehrismann <jehrismann@mirantis.com>
nevalla
changed the title
This was referenced Jun 24, 2020
Merged
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced the code which tested the eTag header with code that runs the existing binary and gets its version. Did not modify the similar code in download_kubectl.ts (used for the download:kubectl yarn target) because this downloader is hard-coded to use the google site for kubernetes, for which the eTag currently corresponds to the md5sum. Also, this downloader pulls binaries for the various platforms. Only the binary native to the build system can be easily run.
Tested on MacOS (docker desktop, kind), and Linux (microk8s, minikube, and conjure, using the Chinese (azure) mirror for downloading the binaries)
fixes #395
Signed-off-by: Jim Ehrismann jehrismann@mirantis.com