Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix: sync in sub-frames for common-stores are broken #724

Merged
merged 2 commits into from
Aug 20, 2020
Merged

Fix: sync in sub-frames for common-stores are broken #724

merged 2 commits into from
Aug 20, 2020

Conversation

ixrock
Copy link
Contributor

@ixrock ixrock commented Aug 20, 2020 •
edited
Loading

This PR fixes sync-update within cluster-view for common stores (user/cluster/workloads).

Since managing views moved to iframe instead of webview it stopped receiving updates from main-process via ipcRenderer.on-api.

This also fixes (initially taken issue) refreshing active theme after changing in preferences page on the fly.

@ixrock
fix: sync in sub-frames for common-stores are broken
7cf7756 
Signed-off-by: Roman <ixrock@gmail.com>
@ixrock ixrock added the bug Something isn't working label Aug 20, 2020
@ixrock ixrock requested review from jakolehm and a team August 20, 2020 16:48
@jakolehm jakolehm added this to the 3.6.0 milestone Aug 20, 2020
@ixrock
clean up
fbaaf6e 
Signed-off-by: Roman <ixrock@gmail.com>
@ixrock ixrock merged commit b6a6dad into master Aug 20, 2020
@ixrock ixrock deleted the fix/sync_store_in_cluster_view branch August 20, 2020 17:34
@nevalla nevalla mentioned this pull request Aug 28, 2020
Merged
@nevalla nevalla mentioned this pull request Sep 14, 2020
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jakolehm jakolehm jakolehm approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@ixrock @jakolehm