Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fixing minor light theme issues #744

Merged
merged 4 commits into from
Aug 25, 2020
Merged

Fixing minor light theme issues #744

merged 4 commits into from
Aug 25, 2020

Conversation

aleksfront
Copy link
Contributor

  • Fixing light theme appearance at Landing page
  • Updating chart options when passing new one
  • Fixing Cluster Menu scroll behavior and tooltip

Moved cluster icons to their own block while keeping Add Cluster button always visible.
Before:
Aug-25-2020 16-35-40

After:
Aug-25-2020 16-35-52

Switching theme in Landing Page
Aug-25-2020 16-36-00

@aleksfront
Cluster Menu scrolling & tooltip fixes
849ec4f 
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
@aleksfront
Removing forgotten console.log()
fc2ac59 
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
@aleksfront
Fix Landing Page in light theme
29e7051 
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
@aleksfront
Updating Chart on every componentDidUpdate
c0d4169 
Signed-off-by: Alex Andreev <alex.andreev.email@gmail.com>
@aleksfront aleksfront requested a review from a team August 25, 2020 13:46
@jakolehm jakolehm added area/ui enhancement New feature or request labels Aug 25, 2020
@jakolehm jakolehm added this to the 3.6.0 milestone Aug 25, 2020
jakolehm
jakolehm approved these changes Aug 25, 2020
View reviewed changes
Copy link
Contributor

@jakolehm jakolehm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@aleksfront aleksfront merged commit 886fba1 into master Aug 25, 2020
@aleksfront aleksfront deleted the fix/light-theme-bugs branch August 25, 2020 17:09
@nevalla nevalla mentioned this pull request Aug 28, 2020
Merged
@nevalla nevalla mentioned this pull request Sep 14, 2020
Merged
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@jakolehm jakolehm jakolehm approved these changes

Assignees
No one assigned
Labels
area/ui enhancement New feature or request
Projects
None yet
Milestone
3.6.0
Development

Successfully merging this pull request may close these issues.
2 participants
@aleksfront @jakolehm