Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update yarn installation instructions #469

Merged
merged 2 commits into from
Sep 26, 2024
Merged

Update yarn installation instructions #469

merged 2 commits into from
Sep 26, 2024

Conversation

ajdubovoy
Copy link
Contributor

resolve #464

@ajdubovoy
Copy link
Contributor Author

@Eschults implemented the recommendation in #464.

But, I don't really have a good way of testing it. I did find corepack is installed on my system already, so this bodes well.

@ElvisDot do you maybe have a burner system you could test this on hahah? No worries if no!

I could also always try setting up a DigitalOcean droplet for a day and see if I can run our setup via SSH on Ubuntu, I guess.......

@ajdubovoy ajdubovoy requested a review from Eschults May 22, 2024 08:36
Copy link
Member

@Eschults Eschults left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM++

Sorry Engineering's bandwidth is the same as in #464 (comment) 😕

@ajdubovoy
Copy link
Contributor Author

No worries! But do we feel comfortable merging this without having at least tested it on Windows once?

@Eschults
Copy link
Member

Let's ask in #teachers if someone is on Windows and would be so kind to run the two commands for us 😇

@ajdubovoy
Copy link
Contributor Author

Ok will do!

@ajdubovoy
Copy link
Contributor Author

@ajdubovoy
Copy link
Contributor Author

Hmmm so apparently it doesn't work with our node version on Ubuntu.

https://lewagon-alumni.slack.com/archives/G02NFDT0J/p1716555678386209?thread_ts=1716393474.945849&channel=G02NFDT0J&message_ts=1716555678.386209

I guess should we table merging this until we upgrade mode?

@ElvisDot
Copy link
Contributor

Works on my machine. Did not test a lot just corepack enable and using yarn to install some package.

@ajdubovoy
Copy link
Contributor Author

It also seems like the issue on Natalia's computer was actually some kind of network error we haven't been able to solve yet. I do wonder if the same thing might happen to students, but it's also not necessarily a reason not to merge this

@ajdubovoy
Copy link
Contributor Author

I also think we don't use yarn at any point in the bootcamp anymore, so it wouldn't be a breaking problem if it didn't install on somebody's laptop

@Eschults Eschults merged commit f1d2830 into master Sep 26, 2024
@Eschults
Copy link
Member

👍

@Eschults Eschults deleted the ajdubovoy/464 branch September 26, 2024 17:11
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

WARNING: npm install --global yarn
3 participants