Remove bundled Geolite2 db due to license change #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Due to license change, https://dev.maxmind.com/geoip/geoip2/geolite2/ we are no longer able to download Geolite2 db without manual setting up. 1. Removed db update script 2. Removed bundled db binary from `MMDB` target, `MMDB` now must be inited with a path to the db binary 3. Moved bundled db to test target for only testing purpose. The binary can be released since it was obtained under old license. But there is no way to update it now.
|
LGTM. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Due to license change, https://dev.maxmind.com/geoip/geoip2/geolite2/
we are no longer able to download Geolite2 db without manual setting up.
MMDBtarget,MMDBnow must be inited with a path tothe db binary
can be released since it was obtained under old license. But there is no
way to update it now.
I removed bundled outdated DB instead of just removing the update script.
IMHO, providing an outdated database basically enables some developers to never update the database, which would impact the final user experience. Instead, developers should not depend on MMDB to provide a solution but try to find a way to make sure the database is up to date.
Fixing #14