Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Ts parameterizable #35

Merged
merged 12 commits into from
Aug 23, 2022
Merged

Ts parameterizable #35

merged 12 commits into from
Aug 23, 2022

Conversation

Wonseo-C
Copy link
Collaborator

@Wonseo-C Wonseo-C commented Jul 29, 2022

#23 Task 4
I changed the part of getting paramType.
Then we can parameterize the variable by setting run_args!
(The test will pass if lf-lang/lingua-franca#1310 is merged)

@Wonseo-C Wonseo-C requested a review from cmnrd July 29, 2022 06:26
@Wonseo-C
Copy link
Collaborator Author

Wonseo-C commented Aug 12, 2022

@cmnrd I think this branch is ready to merge!
(lf-lang/lingua-franca#1310: The problem of getTargetType was solved, and this branch was merged. )

Copy link
Contributor

@cmnrd cmnrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

@cmnrd cmnrd merged commit e813616 into main Aug 23, 2022
@cmnrd cmnrd deleted the ts-parameterizable branch August 23, 2022 15:39
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants