Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Rust submodule gets modified when running build-lf-cli #1544

Closed
edwardalee opened this issue Jan 13, 2023 · 3 comments · Fixed by #1546
Closed

Rust submodule gets modified when running build-lf-cli #1544

edwardalee opened this issue Jan 13, 2023 · 3 comments · Fixed by #1546
Assignees
Labels
bug Something isn't working build system rust Related to the Rust target

Comments

@edwardalee
Copy link
Collaborator

When I run

> build-lf-cli -c

and then do

> git status

I get

	modified:  org.lflang/src/lib/rs/runtime-version.properties

What is this about? Should I commit this?
git diff gives this:

diff --git a/org.lflang/src/lib/rs/runtime-version.properties b/org.lflang/src/lib/rs/runtime-version.properties
index f45320cae..9d66df0bf 100644
--- a/org.lflang/src/lib/rs/runtime-version.properties
+++ b/org.lflang/src/lib/rs/runtime-version.properties
@@ -1 +1 @@
-rs = cfb690bd427f33b5567058092fd5e175e294e697
+rs = 868c834f0de46b2cd633892ccafb7768357d3bd9
@edwardalee edwardalee added rust Related to the Rust target bug Something isn't working build system labels Jan 13, 2023
@cmnrd
Copy link
Collaborator

cmnrd commented Jan 13, 2023

I was able to reproduce this and it looks indeed like a bug in build-lf-cli. The behavior is really strange. I have never seen this when using ./gradlew clean buildAll, but on my first try with build-lf-cli my runtime-version.properties also was modified (although to a different version). However, now I cannot reproduce this again... I reverted the change and when I run build-lf-cli it now works as expected... @oowekyala do you have an idea what is going on here?

In any case: the modified file should not be committed.

@oowekyala
Copy link
Collaborator

I think the problem is that the gradle build cache that caches an out-of-date version of the output of git submodule status... I'm working on a fix.

@lhstrh
Copy link
Member

lhstrh commented Jan 13, 2023

I've seen the same behavior as well, and believe I have ignored the file, but I'm not sure. Will check.

cmnrd added a commit that referenced this issue Jan 16, 2023
Fix #1544 - up to date check for updateRustRuntime
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bug Something isn't working build system rust Related to the Rust target
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants