Removed all Xtend dependencies #1051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhstrh
reviewed
Mar 17, 2022
There was a problem hiding this comment.
This looks good to me. There are two things I believe might not be addressed by this:
- I believe that the Oomph config added empty
xtend-gendirectories somewhere, but this might have already gone away in the PR submitted by @soerendomroes; and XtendFormatterEclipse.xmlis no longer needed and should also be removed.
lhstrh
approved these changes
Mar 17, 2022
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since the last xtend file has been ported to java in #1049, all Xtend dependencies can be removed.