Fix banks of modal reactors #1279
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
python code generation
a-sr
commented
Jul 6, 2022
org.lflang/src/org/lflang/generator/python/PythonPortGenerator.java
Outdated
Show resolved
Hide resolved
Soroosh129
reviewed
Jul 6, 2022
org.lflang/src/org/lflang/generator/python/PythonPortGenerator.java
Outdated
Show resolved
Hide resolved
lhstrh
requested changes
Jul 11, 2022
| @@ -2,8 +2,11 @@ | |||
|
|
|||
| import java.util.List; | |||
|
|
|||
| import org.eclipse.xtext.xbase.lib.IterableExtensions; | |||
There was a problem hiding this comment.
We've been avoiding unnecessary dependencies on Xtext/Xbase in our code generators. Could you using something from the standard Java library instead?
There was a problem hiding this comment.
Sure. I removed the usage of that extension.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes code generation for modal reactors to correctly account for banks.
Closes #1264