Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Only record tests in test/*/src #1358

Merged
merged 2 commits into from
Sep 7, 2022
Merged

Only record tests in test/*/src #1358

merged 2 commits into from
Sep 7, 2022

Conversation

oowekyala
Copy link
Collaborator

The current implementation also walked into src-gen. This causes problems with my setup because the Rust runtime repo has some LF files, and since it is copied into src-gen, these were registered as tests and caused failures eg of the formatter tests.

@oowekyala oowekyala requested a review from cmnrd September 7, 2022 09:35
@cmnrd cmnrd requested a review from lhstrh September 7, 2022 12:27
Copy link
Collaborator

@cmnrd cmnrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! But I am also tagging Marten since he knows the tests better

Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for the fix :-)

@lhstrh lhstrh merged commit 2611f38 into master Sep 7, 2022
@lhstrh lhstrh deleted the clem.exclude-src-gen-tests branch September 7, 2022 22:33
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants