Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix to let relative include helper ignore non-C files #1578

Merged
merged 8 commits into from
Jan 30, 2023

Conversation

lhstrh
Copy link
Member

@lhstrh lhstrh commented Jan 30, 2023

Fixes #1576.

@lhstrh lhstrh added the bugfix label Jan 30, 2023
@lhstrh lhstrh requested a review from arengarajan99 January 30, 2023 03:37
@arengarajan99
Copy link
Contributor

arengarajan99 commented Jan 30, 2023

Looks like the problem is stemming from multiple definitions of the main function (one gets done automatically by Arduino to call setup and loop and the other is coming from a test file for the hashset implementation.) Ideally, the test file should not be copied over and it should resolve.

@edwardalee Are you able to move that test file into https://github.com/lf-lang/reactor-c/tree/main/test/general/utils ? It would be the easiest fix as far as Peter and I know.

@lhstrh
Copy link
Member Author

lhstrh commented Jan 30, 2023

Makes sense to have tests either have the word "test" in them or group them in a directory called "test." That way, we can easily ignore them.

@lhstrh
Copy link
Member Author

lhstrh commented Jan 30, 2023

Looks like the problem is stemming from multiple definitions of the main function (one gets done automatically by Arduino to call setup and loop and the other is coming from a test file for the hashset implementation.) Ideally, the test file should not be copied over and it should resolve.

@edwardalee Are you able to move that test file into https://github.com/lf-lang/reactor-c/tree/main/test/general/utils ? It would be the easiest fix as far as Peter and I know.

I went ahead and moved the file. It now also gets run as part of the unit tests.

@lhstrh lhstrh merged commit 46f80ce into master Jan 30, 2023
@lhstrh lhstrh deleted the fix-rel-include-helper branch January 30, 2023 05:32
@arengarajan99 arengarajan99 restored the fix-rel-include-helper branch February 13, 2023 00:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Arduino utility for include files is failing
2 participants