--json and --json-file CLI args add to lfc
#1686
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I am tested it and it works see this pull request |
lhstrh
approved these changes
Apr 5, 2023
The error gets reported with an unexpected line number (not even in the right file) when a mistake is inserted into the type for the list of time values. I do not want to fix this right now (honestly it is the C++ compiler's fault, I do not even know how we would fix this), so instead I will try to cover it up.
|
Thanks for the suggestions and fixes @lhstrh and @petervdonovan - do you think the PR is in good shape for merging now? |
petervdonovan
approved these changes
Apr 7, 2023
Co-authored-by: Peter Donovan <33707478+petervdonovan@users.noreply.github.com>
Co-authored-by: Peter Donovan <33707478+petervdonovan@users.noreply.github.com>
Closed
4 tasks
lhstrh
changed the title
--json and --json-file CLI args add to lfc
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Objective
Allow properties to be passed into
lfcthrough a JSON string or file as an alternative to CLI arguments.Reason
To provide a JSON interface between
lingoandlfc.Tasks
--json,--json-files} mutually exclusive.CliBase.java) to first check for--jsonand--json-fileargs, and if either are given, unpack args and recurse into run().jsonStringToArgsto convert a JSON string to a Lingua Franca args array.--jsonand--json-file.