Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

CodeCov reporting for CLI tests #1688

Merged
merged 6 commits into from
Apr 11, 2023
Merged

CodeCov reporting for CLI tests #1688

merged 6 commits into from
Apr 11, 2023

Conversation

lhstrh
Copy link
Member

@lhstrh lhstrh commented Apr 11, 2023 •
edited
Loading

  • Make sure that new CLI tests are run
  • Enable reporting to CodeCov (for Linux only)

@lhstrh lhstrh requested a review from patilatharva April 11, 2023 15:32
@lhstrh lhstrh marked this pull request as draft April 11, 2023 15:40
@lhstrh lhstrh mentioned this pull request Apr 11, 2023
Closed
2 tasks
@patilatharva
Copy link
Collaborator

Also included a small code cleanup in CliBase.java.

@lhstrh lhstrh marked this pull request as ready for review April 11, 2023 17:19
@lhstrh
Copy link
Member Author

lhstrh commented Apr 11, 2023

This is looking good now... Thanks for the fixes, @patilatharva!

@lhstrh lhstrh merged commit 5f5398e into master Apr 11, 2023
@oowekyala oowekyala deleted the cli-codecov branch May 2, 2023 13:22
@lhstrh lhstrh added the testing label Aug 28, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@patilatharva patilatharva Awaiting requested review from patilatharva

Assignees
No one assigned
Labels
testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lhstrh @patilatharva