Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Struct refactoring for actions and ports #1756

Merged
merged 23 commits into from
May 24, 2023
Merged

Struct refactoring for actions and ports #1756

merged 23 commits into from
May 24, 2023

Conversation

edwardalee
Copy link
Collaborator

@edwardalee edwardalee commented May 20, 2023

This PR refactors the structs associated with ports and actions to make a clearer distinction between fields that are user-visible and those that are only used internally by the runtime. It also adds a parent pointer to the struct for actions. There is a corresponding PR in reactor-c: lf-lang/reactor-c#216.

@edwardalee edwardalee requested a review from erlingrj May 20, 2023 21:32
Copy link
Collaborator

@erlingrj erlingrj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@lhstrh lhstrh merged commit 5d4f107 into master May 24, 2023
@cmnrd cmnrd deleted the class-structure branch June 8, 2023 07:44
@lhstrh lhstrh added the refactoring Code quality enhancement label Aug 28, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
refactoring Code quality enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants