Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Google autoformatter applied to all files #1766

Merged
merged 19 commits into from
May 23, 2023
Merged

Conversation

lhstrh
Copy link
Member

@lhstrh lhstrh commented May 22, 2023

This PR disables ratcheting and applies the Spotless autoformatter to all files.

The following files had Markdown syntax in the documentation, which is not supported by JavaDoc and confuses the formatter. Hence, we also converted whatever Markdown we could find to JavaDoc. The following files were affected:

  • src/org/lflang/generator/c/CGenerator.java
  • src/org/lflang/generator/c/CUtil.java
  • src/org/lflang/generator/RuntimeRange.java
  • src/org/lflang/generator/ReactionInstance.java
  • src/org/lflang/generator/c/CTriggerObjectsGenerator.java
  • src/org/lflang/generator/CodeMap.java
  • src/org/lflang/generator/PortInstance.java
    ...and several others.

This PR also fixes #1723.

@lhstrh lhstrh closed this May 22, 2023
@lhstrh lhstrh force-pushed the spotless-google branch from b921f91 to 1fef9e6 Compare May 22, 2023 21:57
@lhstrh lhstrh reopened this May 22, 2023
@lhstrh lhstrh closed this May 22, 2023
@lhstrh lhstrh force-pushed the spotless-google branch from 46f6a6b to 1fef9e6 Compare May 22, 2023 22:07
@lhstrh lhstrh reopened this May 22, 2023
@petervdonovan petervdonovan merged commit e784c33 into master May 23, 2023
@petervdonovan petervdonovan deleted the spotless-google branch May 23, 2023 00:08
@petervdonovan petervdonovan added the refactoring Code quality enhancement label Aug 26, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
refactoring Code quality enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Update CONTRIBUTING.md after formatting
2 participants