Handling cyclic dependencies for TypeScript federated execution #1925
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
byeonggiljun
changed the title
|
I marked this PR as a "draft" again because I found non-determinism errors in this PR. (Update) |
lhstrh
reviewed
Aug 15, 2023
There was a problem hiding this comment.
Great to see that these test are now passing! Let's do another release of reactor-ts once lf-lang/reactor-ts#198 is merged and then use ^0.6.0 in the package.json.
lhstrh
reviewed
Aug 22, 2023
lhstrh
approved these changes
Aug 22, 2023
|
ts-test (macos-latest) failed because a new conflict was emerged due to another auto-merging enabled branch. |
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
hokeun
approved these changes
Aug 25, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant PR: lf-lang/reactor-ts#198
This PR adds the handling of TPO levels,
PTAG, andport absentmessages for TS-targeted federated execution.