Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Support for named and bodyless reactions in C++ #1933

Merged
merged 6 commits into from
Aug 28, 2023
Merged

Support for named and bodyless reactions in C++ #1933

merged 6 commits into from
Aug 28, 2023

Conversation

cmnrd
Copy link
Collaborator

@cmnrd cmnrd commented Aug 8, 2023

No description provided.

@cmnrd cmnrd added this to the 0.5.0 milestone Aug 8, 2023
@cmnrd cmnrd mentioned this pull request Aug 8, 2023
Open
petervdonovan
petervdonovan approved these changes Aug 8, 2023
View reviewed changes
Copy link
Collaborator

@petervdonovan petervdonovan left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It is remarkable how simple this is in comparison to the C target. LGTM!

lhstrh
lhstrh approved these changes Aug 8, 2023
View reviewed changes
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice! I wish all feature-adding PRs were this simple!

@lhstrh lhstrh changed the title Support named and bodyless reactions in C++ Support for named and bodyless reactions in C++ Aug 8, 2023
@lhstrh lhstrh added this pull request to the merge queue Aug 8, 2023
tanneberger
tanneberger approved these changes Aug 8, 2023
View reviewed changes
test/Cpp/src/hello_bodyless_world.cc Outdated Show resolved Hide resolved
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to Branch Protection failures Aug 8, 2023
You're not authorized to push to this branch. Visit "About protected branches" for more information.
@lhstrh
Copy link
Member

lhstrh commented Aug 27, 2023

Can we include this in v0.5.0?

@cmnrd cmnrd enabled auto-merge August 28, 2023 10:28
@cmnrd cmnrd added the enhancement Enhancement of existing feature label Aug 28, 2023
@cmnrd cmnrd added this pull request to the merge queue Aug 28, 2023
Merged via the queue into master with commit df12816 Aug 28, 2023
@cmnrd cmnrd deleted the bodyless-cpp branch August 28, 2023 13:53
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@petervdonovan petervdonovan petervdonovan approved these changes

@tanneberger tanneberger tanneberger approved these changes

@lhstrh lhstrh lhstrh approved these changes

Assignees
No one assigned
Labels
enhancement Enhancement of existing feature
Projects
None yet
Milestone
0.5.0
Development

Successfully merging this pull request may close these issues.
4 participants
@cmnrd @lhstrh @tanneberger @petervdonovan