Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Tests for lf_set_array and persistent inputs #1987

Merged
merged 3 commits into from
Sep 3, 2023
Merged

Conversation

edwardalee
Copy link
Collaborator

@edwardalee edwardalee commented Sep 1, 2023

I noticed that the lf_set_array function in the C target is not properly tested in the test suite. This adds a test to test it.

This also adds a test of persistent inputs that matches the documentation.

@edwardalee edwardalee requested a review from lhstrh September 1, 2023 14:55
@edwardalee edwardalee changed the title Test lf_set_array Test lf_set_array and persistent inputs Sep 1, 2023
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, modulo formatting. Maybe also add a high level comment that explains what this is meant to do?

@lhstrh lhstrh added this pull request to the merge queue Sep 2, 2023
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Sep 2, 2023
@edwardalee edwardalee added this pull request to the merge queue Sep 3, 2023
Merged via the queue into master with commit ca412c5 Sep 3, 2023
@edwardalee edwardalee deleted the test-lf-set-array branch September 3, 2023 13:10
@lhstrh lhstrh added the testing label Sep 10, 2023
@lhstrh lhstrh changed the title Test lf_set_array and persistent inputs Tests for lf_set_array and persistent inputs Sep 10, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants