-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Bracket list expression for initialization without escaping #2003
Conversation
Fantastic! This is really nice, @oowekyala. It occurs to me that even if we were to aim for a clearer separation between target code and LF code, initializers are probably the places where it would remain to pay off to elegantly mix languages (i.e., without escaping)... |
Looks like our |
371b44c
to
efb8f55
Compare
efb8f55
to
91b219b
Compare
OK, fixed this! |
Thanks Marten for fixing the CI! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks great! The only request I have, is that more Python tests should be updated. For instance ArrayAsParamenter.lf
still uses the old syntax. There might be more.
This is beyond this PR, but we should soon remove the old name(<expr>*)
syntax (#1675).
Fixed the test you mentioned; didn't find any others.
Add an expression kind for Python and TS lists, and Rust arrays.
Fix #1981
This requires an update to the website.