Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Reduced scope for conflicting main reactors check #2180

Merged
merged 1 commit into from
Feb 3, 2024

Conversation

lhstrh
Copy link
Member

@lhstrh lhstrh commented Feb 2, 2024

We do a check to find conflicting main reactors in the package. We should limit the scope of the search to the srcdirectory because there could be other sources present in the package outside of the src directory that should not be labeled as conflicting.

This fix was prompted by the use of the lf-lang/action-check-lf-files which puts a checkout of lingua-franca in the workspace.

Required for lf-lang/lf-pico-template#2.

Copy link
Collaborator

@edwardalee edwardalee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@edwardalee edwardalee added this pull request to the merge queue Feb 3, 2024
Merged via the queue into master with commit 44ae349 Feb 3, 2024
43 checks passed
@edwardalee edwardalee deleted the conflict-check-src-only branch February 3, 2024 21:20
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants