Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Escape special characters in type arguments. #2186

Merged
merged 2 commits into from
Feb 7, 2024

Conversation

petervdonovan
Copy link
Collaborator

This resolves multiple FIXMEs in the code as well as issue #2179.

@petervdonovan petervdonovan linked an issue Feb 6, 2024 that may be closed by this pull request
@petervdonovan petervdonovan requested a review from lhstrh February 6, 2024 07:08
This resolves multiple FIXMEs in the code as well as issue #2179.
@petervdonovan petervdonovan force-pushed the escape-type-arg-special-chars branch from c11505c to f983c1b Compare February 6, 2024 07:10
@petervdonovan petervdonovan added c Related to C target bugfix labels Feb 6, 2024
I think this is OK; this test is inherently both a generics test and a
CCpp test (because the special characters come from using C++), so it
seems fine to put it in either category.

But it should be in the target category so that it is not run on
Windows.
@petervdonovan petervdonovan force-pushed the escape-type-arg-special-chars branch from 96de53c to 258755a Compare February 7, 2024 01:02
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the quick fix, @petervdonovan!

@lhstrh lhstrh enabled auto-merge February 7, 2024 01:45
@lhstrh lhstrh added this pull request to the merge queue Feb 7, 2024
Merged via the queue into master with commit 2f0d82a Feb 7, 2024
43 checks passed
@lhstrh lhstrh deleted the escape-type-arg-special-chars branch February 7, 2024 03:40
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
bugfix c Related to C target
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Generic Reactors does not sanitize characters for filesystem
2 participants