Replacement of javax.inject with com.google.inject
#2253
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lhstrh
approved these changes
Apr 4, 2024
lhstrh
requested changes
Apr 4, 2024
|
I have an Eclipse setup that successfully installs and works with a checked out version of Klighd and ELK. But since the ELK release on Maven has problems, we have not yet released Klighd to test this with a release, only with the main. So it works for me, but I will come back to this before/after the Klighd 3.0.0 release. |
lhstrh
approved these changes
Apr 14, 2024
lhstrh
changed the title
javax.inject with com.google.inject
|
@lhstrh Thanks for merging and making the PR spotless. I seem to have missed this during travel preparations. |
|
No problem! Easy fix 😄 |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Javax will soon be incompatible and is also being removed from KLighd and ELK.
Hence, I suggest to also remove it here (and I need a commit hash to refer to when updating the target platform for Epoch).