Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Xtext bumped to 3.34.0 #2264

Merged
merged 1 commit into from
Apr 23, 2024
Merged

Xtext bumped to 3.34.0 #2264

merged 1 commit into from
Apr 23, 2024

Conversation

lhstrh
Copy link
Member

@lhstrh lhstrh commented Apr 21, 2024

@lhstrh lhstrh added the upgrade label Apr 21, 2024
@lhstrh lhstrh changed the title Xtext 3.34 Xtext bumped to 3.34.0 Apr 21, 2024
@lhstrh lhstrh force-pushed the xtext-3.34 branch 2 times, most recently from c8273b0 to 85208e4 Compare April 21, 2024 18:35
@lhstrh lhstrh changed the title Xtext bumped to 3.34.0 Xtext bumped to 3.33.0 Apr 21, 2024
@soerendomroes
Copy link
Collaborator

soerendomroes commented Apr 22, 2024

@lhstrh Maybe this fails since a few tests still use javax and not com.google.gson for injection. I guess beginning with 2.33 Xtext might also drop support for javax.infject, hence this might fail.

This should affect the LetInferenceTests and LinguaFrancaASTUtilsTest tests.

@lhstrh
Copy link
Member Author

lhstrh commented Apr 22, 2024

OK, let's see: 729d42b

@soerendomroes
Copy link
Collaborator

spotless seems to be missing but it seems to solve the problem.

@lhstrh lhstrh changed the title Xtext bumped to 3.33.0 Xtext bumped to 3.34.0 Apr 22, 2024
@lhstrh lhstrh requested a review from edwardalee April 22, 2024 23:20
@lhstrh lhstrh enabled auto-merge April 22, 2024 23:20
@lhstrh lhstrh disabled auto-merge April 23, 2024 01:14
@lhstrh lhstrh merged commit f840daa into master Apr 23, 2024
24 checks passed
@lhstrh lhstrh deleted the xtext-3.34 branch April 23, 2024 01:14
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants