Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Extensions to the trace-plugin property #2275

Merged
merged 37 commits into from
May 11, 2024
Merged

Conversation

erlingrj
Copy link
Collaborator

@erlingrj erlingrj commented May 7, 2024

This PR addresses a couple of issues:

  • Updating the trace API + several other fixes by Peder
  • code-generating trace plugin option to CMake
  • Allowing to set a RUN cmd to the generated Docker
  • Parsing the tracing and trace-plugin options correctly

There is also a PR in reactor-c with corresponding fixes here: lf-lang/reactor-c#420

@erlingrj erlingrj added the bugfix label May 7, 2024
@lhstrh
Copy link
Member

lhstrh commented May 8, 2024

Looks like lf-lang/reactor-c#420 should be merged first and then pulled into this PR with a submodule update.

@lhstrh lhstrh requested a review from petervdonovan May 9, 2024 18:22
Copy link
Collaborator

@petervdonovan petervdonovan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, except maybe some stray edits to the tests.

test/C/src/ActionDelay.lf Outdated Show resolved Hide resolved
@erlingrj erlingrj force-pushed the trace-plugin-property-fix branch from 4cf17fe to 251c6b4 Compare May 10, 2024 16:40
@erlingrj erlingrj changed the title TracePluginProperty fix Extensions to the trace-plugin property May 10, 2024
@lhstrh lhstrh enabled auto-merge May 11, 2024 04:41
@lhstrh lhstrh added this pull request to the merge queue May 11, 2024
Merged via the queue into master with commit 422eb03 May 11, 2024
24 checks passed
@lhstrh lhstrh deleted the trace-plugin-property-fix branch May 11, 2024 06:21
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants