Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix deadline inference, test GEDF, and remove chain ID #2294

Merged
merged 13 commits into from
May 30, 2024
Merged

Conversation

edwardalee
Copy link
Collaborator

@edwardalee edwardalee commented May 22, 2024

This PR fixes deadline propagation. Previously, a reaction would inherit the deadline of a downstream reaction only if there was a data path through ports to the downstream reaction. This corrects this so that a reaction that is lexically earlier than another reaction in a reactor inherits the deadline of that later reactor.

This PR also adds the test PR 426 of reactor-c that checks for correct behavior of the GEDF scheduler. It also updates reactor-c to include the corrected GEDF scheduler.

This PR also gets rid of the chain_id, which never worked.

@edwardalee edwardalee added enhancement Enhancement of existing feature c Related to C target labels May 22, 2024
@edwardalee edwardalee changed the title Add test for GEDF redesign Fix deadline inference, test GEDF, and remove chain ID May 24, 2024
Copy link
Collaborator

@petervdonovan petervdonovan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this PR is good to merge. The inferred deadline algorithm looks right to me, and I am happy that PeriodicTask checks execution order using physical time instead of using a global variable.

@lhstrh
Copy link
Member

lhstrh commented May 28, 2024

@edwardalee: After lf-lang/reactor-c#426 has been merged, I'll update reactor-c with an interactive rebase and clean up the history.

@edwardalee edwardalee added this pull request to the merge queue May 29, 2024
@lhstrh lhstrh removed this pull request from the merge queue due to a manual request May 29, 2024
@lhstrh
Copy link
Member

lhstrh commented May 29, 2024

I wasn't able to do a full rebase without going through too much trouble because merges with master had already happened along the way, so I just did a small few fixups... But reactor-c points to main now.

@lhstrh lhstrh enabled auto-merge May 29, 2024 05:47
@lhstrh lhstrh added this pull request to the merge queue May 29, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks May 29, 2024
@edwardalee edwardalee added this pull request to the merge queue May 30, 2024
Merged via the queue into master with commit 030f93b May 30, 2024
26 checks passed
@edwardalee edwardalee deleted the gedf branch May 30, 2024 06:10
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
c Related to C target enhancement Enhancement of existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants