Do not require libexecinfo in C++ docker images #2372
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cmnrd
added
enhancement
cmnrd
force-pushed
the
cpp-docker-cmake-fix
branch
from
3d08989 to
e40a6da
Compare
elgeeko1
approved these changes
Jul 22, 2024
Alpine has dropped support for libexecinfo since version 3.17. This PR pulls in lf-lang/reactor-cpp#59 which makes the compilation of reactor-cpp more robust, so that it can handle if backtrace support is not available or provided by an alternative implementation. Consequently, we can remove the current workarounds in the LF code generator.
cmnrd
force-pushed
the
cpp-docker-cmake-fix
branch
from
e40a6da to
2be839f
Compare
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Alpine has dropped support for libexecinfo since version 3.17. This PR pulls in lf-lang/reactor-cpp#59 which makes the compilation of reactor-cpp more robust, so that it can handle if backtrace support is not available or provided by an alternative implementation. Consequently, we can remove the current workarounds in the LF code generator for docker builds.