Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Enable support for tracing in the Python target #568

Merged
merged 1 commit into from
Oct 5, 2021

Conversation

Soroosh129
Copy link
Contributor

From HelloWorld.lf:

target Python {
    tracing: true  // Now supported
};
...

@Soroosh129 Soroosh129 requested review from hokeun and lhstrh October 4, 2021 18:42
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🚀🚀🚀

@codecov
Copy link

codecov bot commented Oct 4, 2021

Codecov Report

Merging #568 (5899b68) into master (ec1f83c) will increase coverage by 0.00%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #568   +/-   ##
=========================================
  Coverage     66.43%   66.43%           
- Complexity     3466     3469    +3     
=========================================
  Files           132      132           
  Lines         22294    22303    +9     
  Branches       2876     2879    +3     
=========================================
+ Hits          14810    14818    +8     
- Misses         6345     6346    +1     
  Partials       1139     1139           
Impacted Files Coverage Δ
org.lflang/src/org/lflang/TargetProperty.java 85.75% <100.00%> (ø)
...tend-gen/org/lflang/generator/PythonGenerator.java 80.33% <0.00%> (+0.04%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ec1f83c...5899b68. Read the comment docs.

@hokeun
Copy link
Member

hokeun commented Oct 4, 2021

Thank you, Soroush! I confirmed that it is working fine.

@lhstrh lhstrh merged commit 4a7971a into master Oct 5, 2021
@Soroosh129 Soroosh129 deleted the python-tracing-support branch October 12, 2021 17:50
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants