Add a federated test for TypeScript

[hokeun]

Add a federated test for TypeScript after fixing issues with federated TypeScript code generation.

[Soroosh129]

This looks good to me!

Nonetheless, I think we should hold off merging this until after #648 is fixed to avoid intermittent test failures.

[lhstrh]

Looks good!

[hokeun]

Thanks, Soroush and Marten!

This looks good to me!

Nonetheless, I think we should hold off merging this until after #648 is fixed to avoid intermittent test failures.

I think #648 should not affect this one since the test only checks if this example successfully runs. That is, this should never fail due to #648, I think. I'll wait for your final comments before merging this. Let me know if you have any concerns!

[Soroosh129]

Oh, taking a second look at the test, shouldn't it keep track of the number of messages received by the PrintMessage reactor and fail if it's not 2?

I think at least a reaction(shutdown) should perhaps be in PrintMessage to confirm that at least one message is received (but I would argue that exactly two messages should be received for the test to pass).

[hokeun]

Oh, taking a second look at the test, shouldn't it keep track of the number of messages received by the PrintMessage reactor and fail if it's not 2?

I think at least a reaction(shutdown) should perhaps be in PrintMessage to confirm that at least one message is received (but I would argue that exactly two messages should be received for the test to pass).

I agree with you that this test needs to be updated to do a better check. I just wanted to make sure we have at least one test that makes sure federated execution itself compiles and works for the TypeScript first. I added a TODO to update the test once the behavior issue (https://github.com/lf-lang/lingua-franca/issues/648) is resolved. But I'd like to have this test in place before I fix that issue. Would this make sense to you?

[Soroosh129]

Yes it makes perfect sense! Thanks for adding the TODO.

[hokeun]

Yes it makes perfect sense! Thanks for adding the TODO.

Thanks, Soroush!