Refactoring: Purge code generators of IFileSystemAccess2. #938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
petervdonovan
force-pushed
the
purge-fsa
branch
2 times, most recently
from
3d492a8 to
e13a722
Compare
petervdonovan
force-pushed
the
purge-fsa
branch
from
e13a722 to
f609e33
Compare
cmnrd
approved these changes
Feb 7, 2022
|
No, I do not know why integration tests are not running. I have heard that switching the base branch and switching back can force some things to update on GitHub, but that did not work here. The CI workflow isn't written to be manually triggered either, though I wonder if it should be. In order to trigger CI, I may have to close this PR and open a new one... |
|
Looks like that did the trick! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#929 is not the first bug that was related to
IFileSystemAccess2(see acf9859). In #929, writing to a file caused an error inorg.eclipse.core.runtime.SubMonitor, a progress reporting class which I could not find the source code for. It is annoying for trivial operations like writing to files to causeIllegalStateExceptions in seemingly unrelated parts of the framework whose state is only ever touched in other, distant parts of our code base.For this reason, this PR eliminates
IFileSystemAccess2wherever possible. In #149, @cmnrd gave a valid reason why we should use theIFileSystemAccess2interface (it specifies thesrc-gendirectory), but this PR preserves the code that gets the location of thesrc-gendirectory from theIFileSystemAccess2.EDIT: This change has been tested in Epoch by compiling at least one test program in Epoch for each target.