Clean up the file writing mechanism #956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The path should be specified as an actual Path object. Also Java provides simpler and more efficient mechanisms for writing files.
| * @param path The file to write the code to. | ||
| */ | ||
| public static void writeToFile(CharSequence text, Path path) throws IOException { | ||
| writeToFile(text.toString(), path); |
There was a problem hiding this comment.
(For context, the original motivation for using CharSequence here instead of String was to avoid calling toString() or getBytes(). The C generator was having out-of-memory errors because of its large strings, and toString() and getBytes() do seem to create copies. However, that is not important anymore since the C generator has been repaired by scalability-banks.)
There was a problem hiding this comment.
Ok, I see. I also find it strange that apparently there is no easy way of writing a string to a file without copying anything.
petervdonovan
approved these changes
Feb 10, 2022
Merged
lhstrh
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The path should be specified as an actual Path object.
Also Java provides simpler and more efficient mechanisms for writing files.