Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Relative paths in lf_types.h #147

Merged
merged 1 commit into from
Jan 20, 2023
Merged

Relative paths in lf_types.h #147

merged 1 commit into from
Jan 20, 2023

Conversation

gundralaa
Copy link
Collaborator

@gundralaa gundralaa commented Jan 20, 2023 •
edited
Loading

changed the modes.h header path to avoid conflict

@gundralaa gundralaa requested review from erlingrj and lhstrh January 20, 2023 20:17
@gundralaa gundralaa mentioned this pull request Jan 20, 2023
Open
@lhstrh lhstrh changed the title use relative paths for lf_types.h Relative paths lf_types.h Jan 20, 2023
lhstrh
lhstrh approved these changes Jan 20, 2023
View reviewed changes
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! Could you leave a brief summary in the description that describes the need for this change? It's good to have that documented. Thanks!

@gundralaa gundralaa merged commit 5ae2538 into main Jan 20, 2023
@lhstrh lhstrh changed the title Relative paths lf_types.h Relative paths in lf_types.h Feb 23, 2023
@lhstrh lhstrh deleted the lftypes_path_change branch February 1, 2024 20:29
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@lhstrh lhstrh lhstrh approved these changes

@erlingrj erlingrj Awaiting requested review from erlingrj

Assignees
No one assigned
Labels
refactoring
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gundralaa @lhstrh