Enclaves tuning #243
Merged
Enclaves tuning #243
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erlingrj
approved these changes
Jun 26, 2023
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR documents GLOBAL_ENVIRONMENT and inserts assertions where it should not be used so that we get assertion failures instead of segmentation faults.
It also renames global_environment to top_level_environment, which more accurate because it does not match GLOBAL_ENVIRONMENT.
This PR also fixes a bug in the audio utility that was calling lf_time_logical(), which now requires an environment argument. In any case, the call was incorrect and not needed.