Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Use of correct federate ID in tracing of absent messages #248

Merged
merged 3 commits into from
Jul 6, 2023
Merged

Use of correct federate ID in tracing of absent messages #248

merged 3 commits into from
Jul 6, 2023

Conversation

ChadliaJerad
Copy link
Collaborator

This PR fixes the wrong federate id when tracing a received ABS message by the RTI.

petervdonovan
petervdonovan approved these changes Jul 6, 2023
View reviewed changes
Copy link
Contributor

@petervdonovan petervdonovan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks Chadlia!

@lhstrh lhstrh changed the title Fix wrong fed id in tracing absent messages Use of correct federate ID in tracing of absent messages Jul 6, 2023
lhstrh
lhstrh approved these changes Jul 6, 2023
View reviewed changes
Copy link
Member

@lhstrh lhstrh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Please squash and merge when all the tests pass.

@ChadliaJerad ChadliaJerad merged commit 9e9f427 into main Jul 6, 2023
@ChadliaJerad ChadliaJerad deleted the fix-tracing-abs branch July 6, 2023 20:42
@lhstrh lhstrh added the bugfix label Aug 28, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@petervdonovan petervdonovan petervdonovan approved these changes

@lhstrh lhstrh lhstrh approved these changes

Assignees
No one assigned
Labels
bugfix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ChadliaJerad @lhstrh @petervdonovan