Fixed overflow bug affecting 32-bit Linux platforms #288
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…d overflows on 32bit archs
|
The test: |
erlingrj
commented
Oct 7, 2023
|
Should we get this little fix merged, @edwardalee? I have tested in on a RPi4 (with a 32bit OS). |
lhstrh
changed the title
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This bug was reported in this issue: lf-lang/lingua-franca#2034
Another reminder of how difficult it is to juggle time representations on different architectures. In general, unless we are dealing with a type of explicit widht, like uint64_t or instant_t, then we must consider that it might be 32-bit on a 32-bit architecture. This goes for any literal value also.