Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Rename semaphore.h/c to lf_semaphore.h/c #340

Merged
merged 2 commits into from
Jan 31, 2024
Merged

Conversation

edwardalee
Copy link
Contributor

This PR addresses a collision that can occur on Linux where CMake tries to include a built-in Linux semaphore.h file (in /usr/include or /usr/local/include) and instead finds the Lingua Franca semaphore.h file. This prevents the browser-ui and mitt examples in the playground from compiling on Linux. To fix this, we rename the LF files lf_semaphore.h/c.

Copy link
Contributor

@petervdonovan petervdonovan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

It has long been on our to-do list to change the include paths so that our own headers are disambiguated better, but I'm in no hurry to do that and this is a good quick fix.

@edwardalee edwardalee merged commit bf6ecd4 into main Jan 31, 2024
28 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants