-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Cleanup pass removing deprecated reactor-body APIs #353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR is ready for review. There is a companion PR in lingua-franca that requires a further companion review in the benchmarks repo in order to get all tests to pass. |
erlingrj
approved these changes
Feb 13, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, just some tiny comments
Co-authored-by: erling <erling.jellum@gmail.com>
Co-authored-by: erling <erling.jellum@gmail.com>
Co-authored-by: erling <erling.jellum@gmail.com>
Co-authored-by: erling <erling.jellum@gmail.com>
Since these are breaking changes, this suggests that the next version will be |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes old, deprecated API macros originally used in early versions of the C runtime in reaction bodies. This enables substantial code simplification and clarification. Specifically, the following macros are removed:
This PR also fixes a bug (see #352). A companion PR in lingua-franca updates tests that had been using the deprecated API.
Some API functions have also been removed:
get_current_tag
(uself_tag
)get_elapsed_physical_time
(uself_time_physical_elapsed
)error_print_and_exit
(uself_print_error_and_exit
)