Fix clock sync init option #414
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erlingrj
approved these changes
Apr 25, 2024
There was a problem hiding this comment.
Thanks for fixing this, my bad for not including the _LF_CLOCK_SYNC_INITIAL compiler flag when I did that refactoring.
However, I don't see how this should affect flakyness? If all federations run on the same host, then running clock sync between them will just introduce clock sync error.
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug where clock synchronization was not being done when the clock-sync target option was set to
init, which is the default.This also fixes a bug where if the clock-sync-options field collect-stats was set to true, stats would not be collected.
This also fixes an unrelated warning in net_util.c.