Skip to content

Commit

Permalink
update CI config
Browse files Browse the repository at this point in the history
  • Loading branch information
cmnrd committed Aug 15, 2024
1 parent c40d67c commit 8ded983
Show file tree
Hide file tree
Showing 4 changed files with 26 additions and 15 deletions.
10 changes: 3 additions & 7 deletions .github/workflows/clang-format.yml
Original file line number Diff line number Diff line change
@@ -1,17 +1,13 @@
name: clang-format-review
name: check clang-format

# You can be more specific, but it currently only works on pull requests
on: [pull_request]

jobs:
clang-format:
runs-on: ubuntu-20.04
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v2
- name: Install clang-tidy
run: |
sudo apt-get update
sudo apt-get install -y clang-tidy
- uses: actions/checkout@v4
- name: Analyze
run: |
clang-format --dry-run --Werror -style=file $(find ./ -name '*.cc' -print)
Expand Down
20 changes: 20 additions & 0 deletions .github/workflows/clang-tidy.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
name: check clang-tidy

# You can be more specific, but it currently only works on pull requests
on: [pull_request]

jobs:
clang-tidy:
runs-on: ubuntu-24.04
steps:
- uses: actions/checkout@v4
- name: configure
run: |
mkdir build
cd build
cmake ..
- name: build the library
run: cmake --build build
- name: build examples
run:
cmake --build build --target examples
9 changes: 2 additions & 7 deletions .github/workflows/main.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -17,17 +17,12 @@ jobs:
os: [ubuntu-latest, windows-latest, macos-latest]

steps:
- uses: actions/checkout@v1
- name: Install clang-tidy
run: |
sudo apt-get update
sudo apt-get install -y clang-tidy
if: matrix.os == 'ubuntu-latest'
- uses: actions/checkout@v4
- name: configure
run: |
mkdir build
cd build
cmake ..
cmake .. -DREACTOR_CPP_CLANG_TIDY=Off
- name: build the library
run: cmake --build build
- name: build examples
Expand Down
2 changes: 1 addition & 1 deletion include/reactor-cpp/value_ptr.hh
Original file line number Diff line number Diff line change
Expand Up @@ -355,7 +355,7 @@ public:
* class:`ImmutableValuePtr`, the value is deleted.
* @endrst
*/
auto operator=(ImmutableValuePtr&& ptr) -> ImmutableValuePtr& = default;
auto operator=(ImmutableValuePtr&& ptr) noexcept -> ImmutableValuePtr& = default;

/**
* Retrieve a raw pointer to the managed value.
Expand Down

0 comments on commit 8ded983

Please # to comment.