Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Relocation of unistd.h and execinfo.h includes to void namespace pollution #14

Merged
merged 1 commit into from
Jun 20, 2022

Conversation

erlingrj
Copy link
Contributor

@erlingrj erlingrj commented Jun 3, 2022

This way user code can use those header files as well

Copy link
Contributor

@cmnrd cmnrd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. Thanks!

@cmnrd
Copy link
Contributor

cmnrd commented Jun 20, 2022

@revol-xut looks like there is a problem with the nix CI job. Could you take a look?

@cmnrd cmnrd merged commit eebdca0 into lf-lang:master Jun 20, 2022
@lhstrh lhstrh changed the title Move unistd.h and execinfo.h includes out of reactor namespace Relocation of unistd.h and execinfo.h includes to void namespace pollution Jul 20, 2022
@lhstrh lhstrh added the enhancement Enhancement of existing feature label Jul 20, 2022
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
enhancement Enhancement of existing feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants