Reskin chart #33
Merged
Reskin chart #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Looks a tad goofy if there's overflow, but mostly alright.
Removes hardcoded colors (may bring back) in favor of CSS as set by the hosting page. Moves the SVG test fn to the `Dev` module.
Introduces some inline styles to fix upstream
Removes some ad-hoc styles in deference to upstream.
Bitten again by the linux v. macOS precision bug? Will fix when coming back to transits.
Merged
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Major refactor of chart UI, using styles from Firmament.
Before
After