feat(runner-controller): Add public IP address to network interface creation #89
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…reation This commit adds a new feature to the runner-controller by including the creation of a public IP address when creating a network interface. The public IP address is created with a name and SKU, which are specified in the code. This change is specifically so I'm able to access the VMs that are spun up by GATR. I need this access to debug why the `runner-init` script for Windows is not completing successfully.
This commit fixes an issue where the public IP address was not being created before being referenced by the network interface card (NIC). The code now creates the public IP address first, waits for it to be ready, and then references its ID when creating the NIC. This ensures that the NIC is properly configured with a valid public IP address.
Will this change add public ip to all runner Vm's being created? |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR (single commit) adds a new feature to the runner-controller by including the creation of a public IP address when creating a network interface. The public IP address is created with a name and SKU, which are specified in the code.
This change is specifically so I'm able to access the VMs that are spun up by GATR. I need this access to debug why the
runner-initscript for Windows is not completing successfully.