Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Action fails on plans with no changes #30

Closed
stevie- opened this issue Jun 9, 2022 · 3 comments
Closed

Action fails on plans with no changes #30

stevie- opened this issue Jun 9, 2022 · 3 comments
Assignees
@anthonygauthier @christopherswarren
Labels
bug Something isn't working released

Comments

@stevie-
Copy link

stevie- commented Jun 9, 2022

If we pass a plan with no changes to this action we get an error.

Run liatrio/terraform-change-pr-commenter@v1.3.1
  with:
    json-file: /home/runner/work/terragrunt-action/terragrunt-action/examples/test-pr-comment-terragrunt-no-change/test-no-change/tfplan.json
  
    github-token: ***
    expand-comment: false
  env:
    TERRAFORM_VERSION: 1.1.9
    TERRAGRUNT_VERSION: 0.37.1
Found PR # 7 from workflow context - proceeding to comment.
Error: resource_changes is not iterable

We can reproduce it with an empty main.tf:
https://github.com/datadrivers/terragrunt-action/runs/6811210907?check_suite_focus=true#step:3:243
@RobertKelly
Copy link
Contributor

Thanks for reporting. Must have escaped the last refactor test scenario. We'll get this corrected.

@anthonygauthier anthonygauthier self-assigned this Jun 9, 2022
@anthonygauthier anthonygauthier added the bug Something isn't working label Jun 9, 2022
github-actions bot pushed a commit that referenced this issue Jun 9, 2022
@semantic-release-bot
chore(release): 1.3.2 [skip ci]
4effb80 
## [1.3.2](v1.3.1...v1.3.2) (2022-06-09)

### Bug Fixes

* [#30](#30) empty plan would failed the action ([#31](#31)) ([c4ea052](c4ea052))
@liatrio-bot
Copy link

🎉 This issue has been resolved in version 1.3.2 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

@stevie-
Copy link
Author

stevie- commented Jun 9, 2022

thank you, works now
datadrivers/terragrunt-action#8

# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@anthonygauthier anthonygauthier

@christopherswarren christopherswarren

Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
5 participants
@stevie- @RobertKelly @anthonygauthier @christopherswarren @liatrio-bot